diff options
| author | David Pi <david.pinho@gmail.com> | 2020-11-12 07:47:58 +0000 |
|---|---|---|
| committer | mormj <34754695+mormj@users.noreply.github.com> | 2020-12-17 07:53:24 -0500 |
| commit | c4f46bfa6d790c57018f9c6fca264bb9e01a2854 (patch) | |
| tree | d719b6f6362dda414ad7987a027439ff1d7441bf /grc/gui | |
| parent | a95041c384a2998bdddff95ca624d9374095098f (diff) | |
grc: Fix multiple 'Apply' in modify block parameters dialog box
When the modify parameters dialog block is constructed, the instance of
the block to be modified, is passed in. When the apply button is clicked
there is an extraenous flowgraph.import_data() call that re-creates all
blocks in the flowgraph. The consequence is that the block instance
passed to the dialog box is no longer the one in the flowgraph, and so
subsequent Applies have no effect. This change simply removes this call.
Diffstat (limited to 'grc/gui')
| -rw-r--r-- | grc/gui/Application.py | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/grc/gui/Application.py b/grc/gui/Application.py index e512ee565f..349594e73b 100644 --- a/grc/gui/Application.py +++ b/grc/gui/Application.py @@ -544,11 +544,8 @@ class Application(Gtk.Application): response = self.dialog.run() if response in (Gtk.ResponseType.APPLY, Gtk.ResponseType.ACCEPT): page.state_cache.save_new_state(flow_graph.export_data()) - ### Following lines force an complete update of io ports - n = page.state_cache.get_current_state() - flow_graph.import_data(n) + ### Following line forces a complete update of io ports flow_graph_update() - page.saved = False else: # restore the current state n = page.state_cache.get_current_state() |