diff options
| author | Marcus Müller <mmueller@gnuradio.org> | 2019-08-17 17:41:00 +0200 |
|---|---|---|
| committer | Marcus Müller <marcus@hostalia.de> | 2019-08-22 15:05:58 +0200 |
| commit | c6cb3bbc35153a9635d69eddab0d252f7441b854 (patch) | |
| tree | f9ab04c336fa6f228ce0c7b90c3722955a1aa53f /gr-qtgui/lib | |
| parent | bcf35e64b5662f716e0de59e95fdd9ffb02238a7 (diff) | |
Use emplace_back(params) instead of push_back(type(params))
This is C++11: you can convert
std::vector<complextype> vec;
vec.push_back(complextype(foo, bar, baz));
by
std::vector<complextype> vec;
vec.emplace_back(foo, bar, baz);
which saves one unnecessary copy.
This mostly happened in rpc code.
The automated clang-tidy check failed miserably, so most of this was
done by hand.
Diffstat (limited to 'gr-qtgui/lib')
| -rw-r--r-- | gr-qtgui/lib/edit_box_msg_impl.cc | 2 | ||||
| -rw-r--r-- | gr-qtgui/lib/numberdisplayform.cc | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/gr-qtgui/lib/edit_box_msg_impl.cc b/gr-qtgui/lib/edit_box_msg_impl.cc index 4b38a59004..0339276276 100644 --- a/gr-qtgui/lib/edit_box_msg_impl.cc +++ b/gr-qtgui/lib/edit_box_msg_impl.cc @@ -492,7 +492,7 @@ void edit_box_msg_impl::edit_finished() if (conv_ok) { if (even) { im = t; - xv.push_back(gr_complex(re, im)); + xv.emplace_back(re, im); even = false; } else { re = t; diff --git a/gr-qtgui/lib/numberdisplayform.cc b/gr-qtgui/lib/numberdisplayform.cc index f0ae16c7ae..9c027671bc 100644 --- a/gr-qtgui/lib/numberdisplayform.cc +++ b/gr-qtgui/lib/numberdisplayform.cc @@ -40,7 +40,7 @@ NumberDisplayForm::NumberDisplayForm(int nplots, gr::qtgui::graph_t type, QWidge d_min.push_back(+1e32); d_max.push_back(-1e32); d_label.push_back(new QLabel(QString("Data %1").arg(i))); - d_unit.push_back(""); + d_unit.emplace_back(""); d_factor.push_back(1); d_text_box.push_back(new QLabel(QString("0"))); |