diff options
| author | Marcus Müller <mmueller@gnuradio.org> | 2019-08-17 17:41:00 +0200 |
|---|---|---|
| committer | Marcus Müller <marcus@hostalia.de> | 2019-08-22 15:05:58 +0200 |
| commit | c6cb3bbc35153a9635d69eddab0d252f7441b854 (patch) | |
| tree | f9ab04c336fa6f228ce0c7b90c3722955a1aa53f /gr-fft | |
| parent | bcf35e64b5662f716e0de59e95fdd9ffb02238a7 (diff) | |
Use emplace_back(params) instead of push_back(type(params))
This is C++11: you can convert
std::vector<complextype> vec;
vec.push_back(complextype(foo, bar, baz));
by
std::vector<complextype> vec;
vec.emplace_back(foo, bar, baz);
which saves one unnecessary copy.
This mostly happened in rpc code.
The automated clang-tidy check failed miserably, so most of this was
done by hand.
Diffstat (limited to 'gr-fft')
| -rw-r--r-- | gr-fft/lib/ctrlport_probe_psd_impl.cc | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/gr-fft/lib/ctrlport_probe_psd_impl.cc b/gr-fft/lib/ctrlport_probe_psd_impl.cc index cb172666c9..a52418b121 100644 --- a/gr-fft/lib/ctrlport_probe_psd_impl.cc +++ b/gr-fft/lib/ctrlport_probe_psd_impl.cc @@ -137,7 +137,7 @@ void ctrlport_probe_psd_impl::setup_rpc() { #ifdef GR_CTRLPORT int len = static_cast<int>(d_len); - d_rpc_vars.push_back(rpcbasic_sptr( + d_rpc_vars.emplace_back( new rpcbasic_register_get<ctrlport_probe_psd, std::vector<std::complex<float>>>( alias(), d_id.c_str(), @@ -148,9 +148,9 @@ void ctrlport_probe_psd_impl::setup_rpc() "dB", d_desc.c_str(), RPC_PRIVLVL_MIN, - DISPXY | DISPOPTSCATTER))); + DISPXY | DISPOPTSCATTER)); - d_rpc_vars.push_back(rpcbasic_sptr( + d_rpc_vars.emplace_back( new rpcbasic_register_get<ctrlport_probe_psd, int>(alias(), "length", &ctrlport_probe_psd::length, @@ -160,13 +160,13 @@ void ctrlport_probe_psd_impl::setup_rpc() "samples", "get vector length", RPC_PRIVLVL_MIN, - DISPNULL))); + DISPNULL)); -// d_rpc_vars.push_back( -// rpcbasic_sptr(new rpcbasic_register_set<ctrlport_probe_psd, int>( +// d_rpc_vars.emplace_back( +// new rpcbasic_register_set<ctrlport_probe_psd, int>( // alias(), "length", &ctrlport_probe_psd::set_length, // pmt::mp(1), pmt::mp(10*len), pmt::mp(len), -// "samples", "set vector length", RPC_PRIVLVL_MIN, DISPNULL))); +// "samples", "set vector length", RPC_PRIVLVL_MIN, DISPNULL)); #endif /* GR_CTRLPORT */ } |