diff options
author | Marcus Müller <mmueller@gnuradio.org> | 2019-08-17 17:41:00 +0200 |
---|---|---|
committer | Marcus Müller <marcus@hostalia.de> | 2019-08-22 15:05:58 +0200 |
commit | c6cb3bbc35153a9635d69eddab0d252f7441b854 (patch) | |
tree | f9ab04c336fa6f228ce0c7b90c3722955a1aa53f /gr-digital/lib/timing_error_detector.cc | |
parent | bcf35e64b5662f716e0de59e95fdd9ffb02238a7 (diff) |
Use emplace_back(params) instead of push_back(type(params))
This is C++11: you can convert
std::vector<complextype> vec;
vec.push_back(complextype(foo, bar, baz));
by
std::vector<complextype> vec;
vec.emplace_back(foo, bar, baz);
which saves one unnecessary copy.
This mostly happened in rpc code.
The automated clang-tidy check failed miserably, so most of this was
done by hand.
Diffstat (limited to 'gr-digital/lib/timing_error_detector.cc')
-rw-r--r-- | gr-digital/lib/timing_error_detector.cc | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/gr-digital/lib/timing_error_detector.cc b/gr-digital/lib/timing_error_detector.cc index bb299ea915..18df35ec23 100644 --- a/gr-digital/lib/timing_error_detector.cc +++ b/gr-digital/lib/timing_error_detector.cc @@ -232,11 +232,9 @@ void timing_error_detector::sync_reset() d_input_derivative.assign(d_error_depth, gr_complex(0.0f, 0.0f)); if (d_constellation) { - std::deque<gr_complex>::iterator it; - d_decision.clear(); - for (it = d_input.begin(); it != d_input.end(); ++it) - d_decision.push_back(gr_complex(0.0f, 0.0f)); - // d_decision.push_back(slice(*it)); + d_decision.assign(d_input.size(), gr_complex(0.0f, 0.0f)); + // for (it = d_input.begin(); it != d_input.end(); ++it) + // d_decision.push_back(slice(*it)); } sync_reset_input_clock(); |