diff options
| author | japm48 <japm48@users.noreply.github.com> | 2020-04-01 03:26:52 +0200 |
|---|---|---|
| committer | Michael Dickens <michael.dickens@ettus.com> | 2020-04-14 15:47:29 -0400 |
| commit | d0a351a6fc2f018f36f6e89395f346707a059099 (patch) | |
| tree | b5a2389eeee92a5441a31597ecd6b45fcee9baff /gr-blocks/lib/wavfile_source_impl.cc | |
| parent | c1a91d140919518de18eda1fd5b598b2c11ef0cd (diff) | |
blocks: fix wavfile test
The example test_16bit_1chunk.wav was invalid even if the tests passed.
This file caused errors in ffprobe (from ffmpeg) and wave (from python
standard lib).
This is what changed:
- LIST chunk corrected, according to spec. Previously `ffprobe` complained:
[wav @ 0x5653f92d6dc0] too short LIST tag
- File size corrected. Previously the test assumed that the resulting
headers to be identical, this is now taken into account.
Because of this, python's `wave` did not work. This is added to the test.
Parser is updated to check file size.
- Tests that did not close opened files were corrected.
References:
[1] https://sites.google.com/site/musicgapi/technical-documents/wav-file-format
[2] http://www-mmsp.ece.mcgill.ca/Documents/AudioFormats/WAVE/Docs/riffmci.pdf
Diffstat (limited to 'gr-blocks/lib/wavfile_source_impl.cc')
| -rw-r--r-- | gr-blocks/lib/wavfile_source_impl.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gr-blocks/lib/wavfile_source_impl.cc b/gr-blocks/lib/wavfile_source_impl.cc index 0bd1209757..8c17724393 100644 --- a/gr-blocks/lib/wavfile_source_impl.cc +++ b/gr-blocks/lib/wavfile_source_impl.cc @@ -1,6 +1,6 @@ /* -*- c++ -*- */ /* - * Copyright 2004,2008,2010,2013 Free Software Foundation, Inc. + * Copyright 2004,2008,2010,2013,2020 Free Software Foundation, Inc. * * This file is part of GNU Radio * |