summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJosh Morman <mormjb@gmail.com>2020-06-11 08:14:06 -0400
committerJosh Morman <mormjb@gmail.com>2020-06-11 08:14:06 -0400
commit3c302ef4c1655ff27c3f66a924d897a6fdd07060 (patch)
tree7d131df650acebebe3d02c23cbac140c7f5e65d9
parent0f7369481c40f4b841de8d4f6eca825e7e7b4bda (diff)
pybind: remove docstring dependency on entire module
When the module is used as a dependency for the docstring substitution task, any change to any file in the module will cause the regeneration of the bindings for the entire module and all modules that are dependent on that one. There is still probably a better way tie the docstring substitution into the custom commands, per file
-rw-r--r--cmake/Modules/GrPybind.cmake6
-rw-r--r--gr-digital/python/digital/bindings/CMakeLists.txt2
-rw-r--r--gr-vocoder/python/vocoder/bindings/CMakeLists.txt2
3 files changed, 5 insertions, 5 deletions
diff --git a/cmake/Modules/GrPybind.cmake b/cmake/Modules/GrPybind.cmake
index 5486296a3..fd5c9a251 100644
--- a/cmake/Modules/GrPybind.cmake
+++ b/cmake/Modules/GrPybind.cmake
@@ -20,7 +20,7 @@ if(ENABLE_DOXYGEN)
"--output_dir" ${CMAKE_CURRENT_BINARY_DIR}
"--filter" ${filter}
COMMENT "Adding docstrings into ${name} pybind headers ..."
- DEPENDS gnuradio_docstrings gnuradio-${MODULE_NAME})
+ DEPENDS gnuradio_docstrings)
add_custom_target(${name}_docstrings ALL DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/docstring_status)
else(ENABLE_DOXYGEN)
add_custom_command(
@@ -133,7 +133,7 @@ if(ENABLE_DOXYGEN)
"--output_dir" ${CMAKE_CURRENT_BINARY_DIR}
"--filter" ${filter}
COMMENT "Adding docstrings into ${name} pybind headers ..."
- DEPENDS gnuradio_docstrings gnuradio-${MODULE_NAME})
+ DEPENDS gnuradio_docstrings)
add_custom_target(${name}_docstrings ALL DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/docstring_status)
else(ENABLE_DOXYGEN)
add_custom_command(
@@ -254,7 +254,7 @@ if(ENABLE_DOXYGEN)
"--output_dir" ${CMAKE_CURRENT_BINARY_DIR}
"--filter" ${filter}
COMMENT "Adding docstrings into ${name} pybind headers ..."
- DEPENDS extracted_docstrings gnuradio-${MODULE_NAME})
+ DEPENDS extracted_docstrings)
add_custom_target(${name}_docstrings ALL DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/docstring_status)
else(ENABLE_DOXYGEN)
add_custom_command(
diff --git a/gr-digital/python/digital/bindings/CMakeLists.txt b/gr-digital/python/digital/bindings/CMakeLists.txt
index 51c0493c0..97e3bd1b6 100644
--- a/gr-digital/python/digital/bindings/CMakeLists.txt
+++ b/gr-digital/python/digital/bindings/CMakeLists.txt
@@ -93,7 +93,7 @@ list(APPEND digital_python_files
timing_error_detector_type_python.cc
python_bindings.cc)
-GR_PYBIND_MAKE(digital
+GR_PYBIND_MAKE_CHECK_HASH(digital
../../..
gr::digital
"${digital_python_files}")
diff --git a/gr-vocoder/python/vocoder/bindings/CMakeLists.txt b/gr-vocoder/python/vocoder/bindings/CMakeLists.txt
index d059dc23f..48f73546c 100644
--- a/gr-vocoder/python/vocoder/bindings/CMakeLists.txt
+++ b/gr-vocoder/python/vocoder/bindings/CMakeLists.txt
@@ -56,7 +56,7 @@ if(ENABLE_DOXYGEN)
"--output_dir" ${CMAKE_CURRENT_BINARY_DIR}
"--filter" gr::vocoder
COMMENT "Adding docstrings into vocoder pybind headers ..."
- DEPENDS gnuradio_docstrings gnuradio-vocoder)
+ DEPENDS gnuradio_docstrings)
add_custom_target(vocoder_docstrings ALL DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/docstring_status)
else(ENABLE_DOXYGEN)
add_custom_command(