Bug #487

grc: disabled block IDs renamed when copied if duplicate

Added by Josh Blum over 1 year ago. Updated about 1 month ago.

Status:Assigned Start date:02/22/2012
Priority:Normal Due date:
Assignee:Josh Blum % Done:

0%
Category:grc
Target version:-
Resolution:

Description

When a block is copy/pasted, its ID is renamed if a block of that ID already exists. This behavior should not be in effect for disabled blocks.

History

#1
Updated by Sreeraj Rajendran about 1 month ago

Josh,

Is this really a bug?. Renaming the block id while pasting, even if the block id is not unique when checked with a "disabled" block, will help to avoid block_id checks while re-enabling "disabled blocks".

If my understanding is right in line 158 of FlowGraph.py

if param_value in [block.get_id() if block.get_enabled() else '' for block in self.get_blocks()]:

+ some id checks during BLOCK_ENABLE are required for this.

Also available in: Atom PDF